Skip to content

Conversation

iossocket
Copy link
Contributor

Summary

We are working on a lending protocol that integrates pyth on Starknet and would like to use the latest versions of snforge and scarb.

Rationale

Getting conflicts when using the latest scarb.

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code

No logic change, update the dependencies(openzeppelin, snforge_std), change some syntax in unit tests caused by snforge break changes.

Copy link

vercel bot commented Apr 8, 2025

@iossocket is attempting to deploy a commit to the Pyth Network Team on Vercel.

A member of the Team first needs to authorize it.

@iossocket iossocket mentioned this pull request Apr 8, 2025
@Riateche
Copy link
Contributor

Riateche commented Apr 9, 2025

Looks good! Can you please fix the CI issues? I think you need to bump the rust toolchain version in .github/workflows/ci-starknet-tools.yml from 1.78.0 to 1.86.0. You also need to run scarb fmt to reformat the code.

@iossocket iossocket requested a review from a team as a code owner April 10, 2025 00:39
@iossocket
Copy link
Contributor Author

@Riateche Thanks for your reviewing, have updated the pr, looks like the CI would not be triggered automatically, pending review

@iossocket
Copy link
Contributor Author

Hi @Riateche, I have replaced the dojo with starknet-devnet, and verified the workflow on my forked https://github.com/iossocket/pyth-crosschain/actions
Please help to review, thanks


1. Install Starkli (a cli tool for Starknet) by following [the installation instructions](https://github.com/xJonathanLEI/starkli).
2. Install Katana (a local Starknet node) by following [the installation instructions](https://book.starknet.io/ch02-04-katana.html).
2. Install Devnet (a local Starknet node) by following [the installation instructions](https://book.starknet.io/ch02-04-katana.html).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the link to the installation instructions as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, updated

Copy link
Contributor

@Riateche Riateche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, thanks!

@Riateche Riateche merged commit ef3a901 into pyth-network:main Apr 23, 2025
4 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants