-
Notifications
You must be signed in to change notification settings - Fork 301
scarb & snforge upgrade #2570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scarb & snforge upgrade #2570
Conversation
@iossocket is attempting to deploy a commit to the Pyth Network Team on Vercel. A member of the Team first needs to authorize it. |
Looks good! Can you please fix the CI issues? I think you need to bump the rust toolchain version in |
@Riateche Thanks for your reviewing, have updated the pr, looks like the CI would not be triggered automatically, pending review |
Hi @Riateche, I have replaced the dojo with starknet-devnet, and verified the workflow on my forked https://github.com/iossocket/pyth-crosschain/actions |
|
||
1. Install Starkli (a cli tool for Starknet) by following [the installation instructions](https://github.com/xJonathanLEI/starkli). | ||
2. Install Katana (a local Starknet node) by following [the installation instructions](https://book.starknet.io/ch02-04-katana.html). | ||
2. Install Devnet (a local Starknet node) by following [the installation instructions](https://book.starknet.io/ch02-04-katana.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update the link to the installation instructions as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, thanks!
Summary
We are working on a lending protocol that integrates pyth on Starknet and would like to use the latest versions of snforge and scarb.
Rationale
Getting conflicts when using the latest scarb.
How has this been tested?
No logic change, update the dependencies(openzeppelin, snforge_std), change some syntax in unit tests caused by snforge break changes.